Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #398 FastAPI integration fails if docs are disabled. #454

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This resolves the issue #398 preventing users from disabling docs. Instead of assuming that a router should always have four routes we check if any of the routs are not the standard FastAPI routes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell force-pushed the fixed/issue-398-fastapi-empty-router branch from 0b02508 to fd77d88 Compare July 12, 2024 18:36
@danielmorell danielmorell force-pushed the fixed/issue-398-fastapi-empty-router branch from fd77d88 to caa368a Compare July 12, 2024 18:43
@danielmorell danielmorell marked this pull request as draft July 12, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastAPI integration fails if docs are disabled
1 participant