Add safe_repr option to serializer and expose serializer's whitelist_… #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses #80. |
coryvirok
added a commit
that referenced
this pull request
Dec 28, 2015
Add safe_repr option to serializer and expose serializer's whitelist_…
| @@ -287,7 +287,8 @@ def _get_pylons_request(): | |||
| 'locals': { | |||
| 'enabled': True, | |||
| 'safe_repr': True, | |||
| 'sizes': DEFAULT_LOCALS_SIZES | |||
| 'sizes': DEFAULT_LOCALS_SIZES, | |||
| 'whitelisted_types': [] | |||
There was a problem hiding this comment.
Uh, is it whitelist_types or whitelisted_types? Looks like the param that SerializableTransform takes is the former. Any reason for them to be different?
There was a problem hiding this comment.
'whitelisted_types' is what I want it to be however SerializableTransform uses 'whitelist_types'. I didn't want to cause a breaking change so I kept the later but used the new name for a new config option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…types param
This allows users to configure Rollbar to use
repr(obj)during theserialization stage.
@jfarrimo cc @brianr