Collect crashes with stacktraces #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove RollbarPLCrashReporter library.
Simplify reporting
Remove faulty Out of Memory detection
Collect and report all types of crashes together with full stack trace information
Provide useful error descriptions on all use cases that trigger crash reporting.
Validate crash reports before diagnosis, propagating errors. Simplified validation and error propagation. Unit tests.
ijsnow
approved these changes
Feb 16, 2023
| # s.license = "MIT (example)" | ||
| s.resource = "rollbar-logo.png" | ||
| s.authors = { "Andrey Kornich (Wide Spectrum Computing LLC)" => "akornich@gmail.com", | ||
| "Rollbar" => "support@rollbar.com" } |
There was a problem hiding this comment.
Meh. My commits have my name.
This should be changed to just Rollbar, though methinks.
| "\nApplication Specific Information:" | ||
| "*** Terminating app due to uncaught exception '" *? exception?.name *? "' , reason: '" *? exception?.reason *? "'" | ||
|
|
||
| if report.exceptionType == .zombie { |
| // "rdi", "rsi", "rbp", "rsp", | ||
| // "r8", "r9", "r10", "r11", "r12", "r13", "r14", "r15", | ||
| // "rip", "rfl", "cr2" | ||
| //] |
There was a problem hiding this comment.
I wanted to keep these regs for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a collection of all previously approved PRs, not intended for review.
Each commit has a link to its corresponding approved PR.
Type of change