Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Restart Rollbar with new access token without requiring submission #272

Merged
merged 1 commit into from Mar 21, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Mar 20, 2023

Description of the change

This PR ensures that the Rollbar Apple SDK demo properly restarts Rollbar when an access token changes and avoids cases where a user would think the access token was updated but wasn't really.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

  • Not being tracked.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Mar 20, 2023
@matux matux merged commit 51536dc into master Mar 21, 2023
1 check passed
@matux matux deleted the update_token_bug branch March 22, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants