Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MIT License #6

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Add MIT License #6

merged 2 commits into from
Sep 11, 2020

Conversation

mrunalk
Copy link
Contributor

@mrunalk mrunalk commented Sep 11, 2020 •
edited
Loading

Description of the change

Add MIT license text and update readme

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

francescocrippa
francescocrippa approved these changes Sep 11, 2020
View reviewed changes
Copy link

@francescocrippa francescocrippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrunalk
Copy link
Contributor Author

mrunalk commented Sep 11, 2020

Thanks @francescocrippa and @christopherseaman.

@mrunalk mrunalk merged commit dc967c4 into master Sep 11, 2020
@ajtran ajtran deleted the add-license-1 branch April 4, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherseaman christopherseaman christopherseaman approved these changes

@francescocrippa francescocrippa francescocrippa approved these changes

@coryvirok coryvirok Awaiting requested review from coryvirok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrunalk @christopherseaman @francescocrippa