Skip to content

Commit

Permalink
BREAKING CHANGE: Remove support for Ruby 1.9.3, support >=2.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
waltjones committed Aug 26, 2020
1 parent db7b081 commit 544ee27
Show file tree
Hide file tree
Showing 15 changed files with 63 additions and 192 deletions.
16 changes: 0 additions & 16 deletions .travis.yml
Expand Up @@ -5,7 +5,6 @@ services:
language: ruby

rvm:
- 1.9.3
- 2.0.0
- 2.1.0
- 2.2.2
Expand Down Expand Up @@ -73,12 +72,6 @@ matrix:
exclude:
# Don't run tests for non-jruby environments with the JDK.
# NOTE: openjdk7 is missing from these exclusions so that Travis will run at least 1 build for the given rvm.
- rvm: 1.9.3
jdk: openjdk8
- rvm: 1.9.3
jdk: oraclejdk8
- rvm: 1.9.3
jdk: oraclejdk9
- rvm: 2.0.0
jdk: openjdk8
- rvm: 2.0.0
Expand Down Expand Up @@ -149,15 +142,6 @@ matrix:
- rvm: 2.4.5
gemfile: gemfiles/rails60.gemfile
# Rails 5.x requires Ruby 2.2.2 or higher
- rvm: 1.9.3
gemfile: gemfiles/rails50.gemfile
- rvm: 1.9.3
gemfile: gemfiles/rails51.gemfile
- rvm: 1.9.3
gemfile: gemfiles/rails52.gemfile
- rvm: 1.9.3
gemfile: gemfiles/rails60.gemfile
# Rails 5.x requires Ruby 2.2.2 or higher
- rvm: 2.0.0
gemfile: gemfiles/rails50.gemfile
- rvm: 2.0.0
Expand Down
17 changes: 5 additions & 12 deletions Gemfile
Expand Up @@ -44,18 +44,11 @@ platforms :rbx do
gem 'rubysl', '~> 2.0' unless RUBY_VERSION.start_with?('1')
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'json', '1.8.6'
gem 'shoryuken', '>= 4.0.0', '<= 4.0.2'
gem 'sucker_punch', '~> 1.0'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false # rubocop:disable Bundler/DuplicatedGem
gem 'codacy-coverage'
gem 'shoryuken' # rubocop:disable Bundler/DuplicatedGem
gem 'simplecov'
gem 'sucker_punch', '~> 2.0' # rubocop:disable Bundler/DuplicatedGem
end
gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'shoryuken'
gem 'simplecov'
gem 'sucker_punch', '~> 2.0'

unless is_jruby
# JRuby doesn't support fork, which is required for this test helper.
Expand Down
18 changes: 10 additions & 8 deletions README.md
Expand Up @@ -4,14 +4,6 @@
[![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=rollbar&package-manager=bundler&version-scheme=semver&target-version=latest)](https://dependabot.com/compatibility-score.html?dependency-name=rollbar&package-manager=bundler&version-scheme=semver&new-version=latest)


> WARNING: Ruby 2.6.0 introduced a new bug bug ([#15472 -
Invalid JSON data being sent from Net::HTTP in some cases with Ruby 2.6.0](https://bugs.ruby-lang.org/issues/15472)) that may result in the Rollbar API returning an error when an exception is reported. (See [rollbar-gem issue #797](https://github.com/rollbar/rollbar-gem/issues/797)).

> UPDATE: This bug is fixed in Ruby 2.6.1, and rollbar-gem has a safe workaround in version >= 2.19.0.
If you need to stay on Ruby 2.6.0 for any reason, make sure you have the latest rollbar-gem.



[Rollbar](https://rollbar.com) is a real-time exception reporting service for Ruby and other languages. The Rollbar service will alert you of problems with your code and help you understand them in a ways never possible before. We love it and we hope you will too.

Rollbar-gem is the SDK for Ruby apps and includes support for apps using Rails, Sinatra, Rack, plain Ruby, and other frameworks.
Expand All @@ -27,10 +19,20 @@ For complete usage instructions and configuration reference, see our [Ruby SDK d

## Compatibility

Version >= 3.0.0 is compatible with Ruby >= 2.0.0.

Version >= 2.19.0 is compatible with Ruby >= 1.9.3.

Version < 2.19.0 is compatible with Ruby >= 1.8.7.

### Ruby 2.6.0

> WARNING: Ruby 2.6.0 introduced a new bug bug ([#15472 -
Invalid JSON data being sent from Net::HTTP in some cases with Ruby 2.6.0](https://bugs.ruby-lang.org/issues/15472)) that may result in the Rollbar API returning an error when an exception is reported. (See [rollbar-gem issue #797](https://github.com/rollbar/rollbar-gem/issues/797)).

> UPDATE: This bug is fixed in Ruby 2.6.1, and rollbar-gem has a safe workaround in version >= 2.19.0.
If you need to stay on Ruby 2.6.0 for any reason, make sure you have the latest rollbar-gem.

## Release History & Changelog

See our [Releases](https://github.com/rollbar/rollbar-gem/releases) page for a list of all releases, including changes.
Expand Down
24 changes: 6 additions & 18 deletions gemfiles/rails30.gemfile
Expand Up @@ -34,17 +34,11 @@ platforms :rbx do
gem 'rubysl-test-unit'
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'sucker_punch', '~> 1.0'
gem 'shoryuken', '>= 4.0.0', '<= 4.0.2'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'
end
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'

gem 'sinatra'
gem 'delayed_job', :require => false
Expand All @@ -54,13 +48,7 @@ gem 'genspec', '>= 0.2.8'
gem 'girl_friday', '>= 0.11.1'
gem 'rspec-command'

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0')
gem 'public_suffix', '< 1.5'
gem 'mime-types', '< 3.0'
gem 'webmock', '< 2.3.0', :require => false
else
gem 'webmock', :require => false
end
gem 'webmock', :require => false

gem 'resque', '< 2.0.0'
gem 'aws-sdk-sqs'
Expand Down
24 changes: 6 additions & 18 deletions gemfiles/rails31.gemfile
Expand Up @@ -33,17 +33,11 @@ platforms :rbx do
gem 'rubysl-test-unit'
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'sucker_punch'
gem 'shoryuken', '>= 4.0.0', '<= 4.0.2'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false
gem 'sucker_punch'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'
end
gem 'capistrano', :require => false
gem 'sucker_punch'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'

gem 'sinatra'
gem 'delayed_job', :require => false
Expand All @@ -53,13 +47,7 @@ gem 'girl_friday'
gem 'generator_spec'
gem 'rspec-command'

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0')
gem 'mime-types', '< 3.0'
gem 'public_suffix', '< 1.5'
gem 'webmock', '< 2.3.0', :require => false
else
gem 'webmock', :require => false
end
gem 'webmock', :require => false

gem 'resque', '< 2.0.0'
gem 'aws-sdk-sqs'
Expand Down
24 changes: 6 additions & 18 deletions gemfiles/rails32.gemfile
Expand Up @@ -35,17 +35,11 @@ platforms :rbx do
gem 'rubysl-test-unit'
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'sucker_punch', '~> 1.0'
gem 'shoryuken', '>= 4.0.0', '<= 4.0.2'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'
end
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'

gem 'delayed_job', :require => false
gem 'redis'
Expand All @@ -56,13 +50,7 @@ gem 'generator_spec'
gem 'girl_friday', '>= 0.11.1'
gem 'rspec-command'

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0')
gem 'mime-types', '< 3.0'
gem 'public_suffix', '< 1.5'
gem 'webmock', '< 2.3.0', :require => false
else
gem 'webmock', :require => false
end
gem 'webmock', :require => false

gem 'resque', '< 2.0.0'
gem 'aws-sdk-sqs'
Expand Down
27 changes: 7 additions & 20 deletions gemfiles/rails40.gemfile
Expand Up @@ -35,19 +35,12 @@ platforms :rbx do
gem 'rubysl-test-unit'
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'sucker_punch', '~> 1.0'
gem 'json', '~> 1.8'
gem 'shoryuken', '>= 4.0.0', '<= 4.0.2'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'json', '~> 2.0'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'
end
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'json', '~> 2.0'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'

gem 'delayed_job', :require => false
gem 'redis'
Expand All @@ -59,13 +52,7 @@ gem 'generator_spec'
gem 'girl_friday', '>= 0.11.1'
gem 'rspec-command'

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0')
gem 'mime-types', '< 3.0'
gem 'public_suffix', '< 1.5'
gem 'webmock', '< 2.3.0', :require => false
else
gem 'webmock', :require => false
end
gem 'webmock', :require => false

gem 'aws-sdk-sqs'

Expand Down
24 changes: 6 additions & 18 deletions gemfiles/rails41.gemfile
Expand Up @@ -32,17 +32,11 @@ platforms :rbx do
gem 'rubysl', '~> 2.0' unless RUBY_VERSION.start_with?('1')
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'sucker_punch', '~> 1.0'
gem 'shoryuken', '>= 4.0.0', '<= 4.0.2'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'
end
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'shoryuken'
gem 'codacy-coverage'
gem 'simplecov'

gem 'delayed_job', :require => false
gem 'redis'
Expand All @@ -54,13 +48,7 @@ gem 'generator_spec'
gem 'girl_friday', '>= 0.11.1'
gem 'rspec-command'

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0')
gem 'mime-types', '< 3.0'
gem 'public_suffix', '< 1.5'
gem 'webmock', '< 2.3.0', :require => false
else
gem 'webmock', :require => false
end
gem 'webmock', :require => false

gem 'resque'
gem 'aws-sdk-sqs'
Expand Down
24 changes: 6 additions & 18 deletions gemfiles/rails42.gemfile
Expand Up @@ -37,13 +37,8 @@ else
gem 'sidekiq', '>= 2.13.0'
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'shoryuken', '>= 4.0.0', '<= 4.0.2'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false
gem 'shoryuken'
end
gem 'capistrano', :require => false
gem 'shoryuken'

gem 'database_cleaner', '~> 1.0.0'
gem 'delayed_job', :require => false
Expand All @@ -56,17 +51,10 @@ gem 'sinatra'

gem 'nokogiri', '~> 1.6.0' if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('2.0')

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0')
gem 'mime-types', '< 3.0'
gem 'public_suffix', '< 1.5'
gem 'sucker_punch', '~> 1.0'
gem 'webmock', '< 2.3.0', :require => false
else
gem 'sucker_punch', '~> 2.0'
gem 'webmock', :require => false
gem 'codacy-coverage'
gem 'simplecov'
end
gem 'sucker_punch', '~> 2.0'
gem 'webmock', :require => false
gem 'codacy-coverage'
gem 'simplecov'

gem 'aws-sdk-sqs'

Expand Down
17 changes: 4 additions & 13 deletions gemfiles/rails50.gemfile
Expand Up @@ -34,15 +34,10 @@ platforms :rbx do
gem 'rubysl', '~> 2.0' unless RUBY_VERSION.start_with?('1')
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'sucker_punch', '~> 1.0'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'codacy-coverage'
gem 'simplecov'
end
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'codacy-coverage'
gem 'simplecov'

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.3')
gem 'rack', '2.1.2'
Expand All @@ -62,10 +57,6 @@ unless is_jruby
gem 'rspec-command'
end

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0')
gem 'mime-types', '< 3.0'
end

gem 'webmock', :require => false

gem 'aws-sdk-sqs'
Expand Down
17 changes: 4 additions & 13 deletions gemfiles/rails51.gemfile
Expand Up @@ -34,15 +34,10 @@ platforms :rbx do
gem 'rubysl', '~> 2.0' unless RUBY_VERSION.start_with?('1')
end

if RUBY_VERSION.start_with?('1.9')
gem 'capistrano', '<= 3.4.1', :require => false
gem 'sucker_punch', '~> 1.0'
elsif RUBY_VERSION.start_with?('2')
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'codacy-coverage'
gem 'simplecov'
end
gem 'capistrano', :require => false
gem 'sucker_punch', '~> 2.0'
gem 'codacy-coverage'
gem 'simplecov'

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.3')
gem 'rack', '2.1.2'
Expand All @@ -63,10 +58,6 @@ unless is_jruby
gem 'rspec-command'
end

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0')
gem 'mime-types', '< 3.0'
end

gem 'webmock', :require => false

gem 'aws-sdk-sqs'
Expand Down

0 comments on commit 544ee27

Please sign in to comment.