Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub all arguments when an ActiveJob is configured not to log arguments #1059

Merged

Conversation

Be-ngt-oH
Copy link
Contributor

Description of the change

Rails 6.1.0 introduced an option for disabling logging of job arguments in ActiveJob[1][2]. This change makes the ActiveJob plugin aware of this config option and scrubs all arguments if we're dealing with a sensitive job.

[1]: https://github.com/rails/rails/releases/tag/v6.1.0
[2]: rails/rails#37660

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Rails 6.1.0 introduced an option for disabling logging of job arguments
in ActiveJob[1][2]. This change makes the ActiveJob plugin aware of this
config option and scrubs all arguments if we're dealing with a sensitive
job.

[1]: https://github.com/rails/rails/releases/tag/v6.1.0
[2]: rails/rails#37660
@waltjones waltjones self-requested a review July 7, 2021 20:54
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the PR.

@waltjones waltjones merged commit b0cf1da into rollbar:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants