Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scrub_whitelist when scrubbing sidekiq job params #1074

Merged

Conversation

gkampjes
Copy link
Contributor

Description of the change

Updates sidekiq job param scrubbing to use configured whitelist.

Every instance of Rollbar::Scrubbers::Params.call(options), except for in the sidekiq plugin, includes the scrub whitelist. It looks like maybe it was accidentally missed for sidekiq?

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@waltjones
Copy link
Contributor

Close/reopen to trigger CI.

@waltjones waltjones closed this Jan 25, 2022
@waltjones waltjones reopened this Jan 25, 2022
@waltjones waltjones self-requested a review January 25, 2022 15:34
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Thank you for the PR.

@waltjones waltjones merged commit 7415fa6 into rollbar:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants