Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove type attribute from script tag #1091

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

waltjones
Copy link
Contributor

Description of the change

This PR removes the type attribute from the script tag that gets inserted for the js snippet. For HTML 5 it is strongly recommended to not include this attribute, and for HTML 4 all browsers assume javascript, so the change is safe there as well. This change will help prevent static analysis warnings for some users.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes #1020

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@waltjones waltjones merged commit 33e7a2c into master Apr 4, 2022
@waltjones waltjones deleted the waltjones/1020/remove-type-text-javascript branch June 27, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary type attribute from Rollbar.js output
2 participants