Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LegacyGemResolver + LegacyEncoder #1093

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Remove LegacyGemResolver + LegacyEncoder #1093

merged 2 commits into from
Jan 4, 2023

Conversation

RicardoTrindade
Copy link
Contributor

@RicardoTrindade RicardoTrindade commented Jun 14, 2022 •
edited

Description of the change

From v3 onwards Rollbar only works with Ruby 2.0 onwards.

  • Gem::GemPathSearcher no longer exists in early version of RubyGems so it's no longer needed to find a GemResolver class dynamically in RollbarRunner.
  • Removes LegacyEncoder since String.encode is available from Ruby 2.0 onwards

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@RicardoTrindade RicardoTrindade marked this pull request as ready for review June 14, 2022 11:42
@RicardoTrindade RicardoTrindade changed the title Remove LegacyGemResolver Remove LegacyGemResolver + LegacyEncoder Jun 14, 2022
waltjones
waltjones approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RicardoTrindade thank you for the PR!

@waltjones waltjones merged commit 20a13ff into rollbar:master Jan 4, 2023
@RicardoTrindade RicardoTrindade deleted the remove_legacy_resolver branch January 4, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RicardoTrindade @waltjones