Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong option message #1110

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

SHinGo-Koba
Copy link
Contributor

@SHinGo-Koba SHinGo-Koba commented Oct 27, 2022

Description of the change

Hi!

I found wrong option message.

This warning message says Wrong 'send_extra_frame_data' value, :none, :app or :full is expected

def send_extra_frame_data=(value)
unless SEND_EXTRA_FRAME_DATA_OPTIONS.include?(value)
logger.warning(
"Wrong 'send_extra_frame_data' value, :none, :app or :full is expected"
)
return
end

However, SEND_EXTRA_FRAME_DATA_OPTIONS only includes :none, :app and :all not :full

SEND_EXTRA_FRAME_DATA_OPTIONS = [:none, :app, :all].freeze

I would be glad if I could help.

Thank you :)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SHinGo-Koba thank you for the PR!

@waltjones waltjones merged commit 4f292fa into rollbar:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants