Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added recovering in case of activity on a closed channel #100

Merged
merged 3 commits into from
Jul 31, 2022
Merged

added recovering in case of activity on a closed channel #100

merged 3 commits into from
Jul 31, 2022

Conversation

pawelsz-rb
Copy link
Collaborator

@pawelsz-rb pawelsz-rb commented Jul 21, 2022 •
edited

Description of the change

  1. Gracefully recover when sending/receiving on the closed channel (protecting from panic)
    issue# : Async transpot can panic #90
  2. Fixed race conditions (also protecting from possible panic)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@pawelsz-rb pawelsz-rb mentioned this pull request Jul 21, 2022
Closed
ijsnow
ijsnow approved these changes Jul 29, 2022
View reviewed changes
Copy link

@ijsnow ijsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pawelsz-rb pawelsz-rb merged commit 204202a into master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijsnow ijsnow ijsnow approved these changes

@nieblara nieblara Awaiting requested review from nieblara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pawelsz-rb @ijsnow