Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export SetContext to support mocking Transport #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjohnso5
Copy link

@bjohnso5 bjohnso5 commented Apr 4, 2024

Description of the change

Export the setContext method of the Transport interface to allow mocking via reimplmentation.

Type of change

(I'm not sure how to categorize this change, if I'm honest - I'm selecting Maintenance)

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally (I was unable to determine what lint rules this might be referencing)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexported function on the Transport interface prevents mocking
1 participant