Skip to content

Commit

Permalink
56: a custom exception handler is not needed as Laravel calls \Log:: …
Browse files Browse the repository at this point in the history
…by default anyway
  • Loading branch information
ArturMoczulski committed Aug 17, 2018
1 parent b9ce5ef commit 14c6c8d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
15 changes: 0 additions & 15 deletions src/ExceptionHandler.php

This file was deleted.

7 changes: 0 additions & 7 deletions src/RollbarServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
use Rollbar\Laravel\MonologHandler;
use Rollbar\RollbarLogger;
use Rollbar\Rollbar;
use Illuminate\Contracts\Debug\ExceptionHandler as LaravelExceptionHandlerContract;
use Rollbar\Laravel\ExceptionHandler;

class RollbarServiceProvider extends ServiceProvider
{
Expand Down Expand Up @@ -57,11 +55,6 @@ public function register()

return $handler;
});

$this->app->bind(
LaravelExceptionHandlerContract::class,
ExceptionHandler::class
);
}

/**
Expand Down

3 comments on commit 14c6c8d

@torkiljohnsen
Copy link

@torkiljohnsen torkiljohnsen commented on 14c6c8d Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturMoczulski This was a great change, as it was assuming that all projects had an App\Exceptions\Handler class. I myself have a custom handler in the project I'm working on, so this didn't work out for us.

Could you make a 4.0.1 release perhaps, and get this change out there?

@ArturMoczulski
Copy link
Author

@ArturMoczulski ArturMoczulski commented on 14c6c8d Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll put together a release right now.

Edit: Actually, I'm sorry, can't do a release now. I need to first come up with a better solution for handling exceptions. Probably will be able to get to that in a week or two.

@torkiljohnsen are you able to work around this for now?

@torkiljohnsen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on dev-master and nervous about it.

Please sign in to comment.