Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the CI test workflow for v8 and Laravel 10 #145

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This PR makes it so that our tests will run for the master branch. This is for the upcoming v8.x and above. Tests for the previous version v7.x of our Laravel package have been moved to the ci-7.x.yml file in #144.

To make the tests run we need to temporarily include the following lines in the install step.

composer config minimum-stability dev
composer config prefer-stable true

Once we release stable v4.0.0 of the core rollbar/rollbar library, we can remove these two lines.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Maintenance General up-keep, or changes that tidy an existing component or process. label Feb 27, 2023
@danielmorell danielmorell merged commit e2fc3fc into master Mar 2, 2023
@danielmorell danielmorell deleted the updated/v8-test-workflow branch March 2, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance General up-keep, or changes that tidy an existing component or process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants