Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the missing 'framework' parameter to the Rollbar config. #148

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Added the missing 'framework' parameter to the Rollbar config. #148

merged 1 commit into from
Mar 6, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

We have not previously been sending the framework information to the Rollbar service. This updates the Rollbar config to include laravel and the version that is being used.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component. label Mar 6, 2023
@danielmorell danielmorell added this to the v8.0.0 milestone Mar 6, 2023
waltjones
waltjones approved these changes Mar 6, 2023
View reviewed changes
Copy link

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielmorell danielmorell merged commit 662717e into master Mar 6, 2023
@danielmorell danielmorell deleted the added/framework branch March 6, 2023 17:59
@danielmorell danielmorell mentioned this pull request Mar 15, 2023
Open
@danielmorell danielmorell linked an issue Mar 15, 2023 that may be closed by this pull request
Framework information is not reported to Rollbar #105
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

@cyrusradfar cyrusradfar Awaiting requested review from cyrusradfar

Assignees
No one assigned
Labels
Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component.
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

Framework information is not reported to Rollbar
2 participants
@danielmorell @waltjones