Merge pull request #238 from rollbar/add-explicit-semicolon-to-js-helper

add an explicit semicolon between snippet and custom js
rollbar · Jul 28, 2017 · d4dccaf · d4dccaf
2 parents bed9404 + babf010
commit d4dccaf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/RollbarJsHelper.php b/src/RollbarJsHelper.php
@@ -50,7 +50,7 @@ public static function buildJs(
     public function addJs($headers = null, $nonce = null, $customJs = "")
     {
         return $this->scriptTag(
-            $this->configJsTag() .$this->jsSnippet() . $customJs,
+            $this->configJsTag() . $this->jsSnippet() . ";" . $customJs,
             $headers,
             $nonce
         );

diff --git a/tests/RollbarJsHelperTest.php b/tests/RollbarJsHelperTest.php
@@ -283,7 +283,7 @@ public function addJsProvider()
                 null,   // 'nonce'
                 "\n<script type=\"text/javascript\">" .
                 "var _rollbarConfig = {};" .
-                $expectedJs .
+                $expectedJs . ";" .
                 "var customJs = true;" .
                 "</script>"
             ),
@@ -295,7 +295,7 @@ public function addJsProvider()
                 null,
                 "\n<script type=\"text/javascript\">" .
                 "var _rollbarConfig = {\"foo\":\"bar\"};" .
-                $expectedJs .
+                $expectedJs . ";" .
                 "var customJs = true;" .
                 "</script>"
             ),
@@ -307,7 +307,7 @@ public function addJsProvider()
                 'stub-nonce',
                 "\n<script type=\"text/javascript\" nonce=\"stub-nonce\">" .
                 "var _rollbarConfig = {};" .
-                $expectedJs .
+                $expectedJs . ";" .
                 "var customJs = true;" .
                 "</script>"
             ),