Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry support #349

Closed
rivkahstandig3636 opened this issue Apr 24, 2018 · 28 comments · Fixed by #634
Closed

Telemetry support #349

rivkahstandig3636 opened this issue Apr 24, 2018 · 28 comments · Fixed by #634
Labels
Status: 3 - Construction The request is being worked on. Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component.
Milestone

Comments

@rivkahstandig3636
Copy link
Contributor

Similar to telemetry in rollbar.js.

This needs to include the config options for enabling/disabling telemetry and scrubbing telemetry data.

@rivkahstandig3636 rivkahstandig3636 added the Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component. label Apr 24, 2018
@rivkahstandig3636 rivkahstandig3636 added this to the v1.5.0 milestone Apr 24, 2018
@zinkovskiy
Copy link
Contributor

So, guys, how are you going to pass telemetry to backend when exception occurs? Do you have a plan how to achieve this?

@rivkahstandig3636
Copy link
Contributor Author

@zinkovskiy We haven't begun working on this feature yet.

@armetiz
Copy link
Contributor

armetiz commented Sep 12, 2018

I'm really interested about this feature!

Our application is logging messages using PSR\Log level info with associated context, those informations could be very useful when debugging.

I'm using monolog.

@jessewgibbs jessewgibbs removed this from the v1.7.0 milestone Oct 10, 2018
@ArturMoczulski ArturMoczulski modified the milestones: v1.7.0, v1.8.0 Oct 18, 2018
@armetiz
Copy link
Contributor

armetiz commented Dec 17, 2018

Any news ?

@Yozhef
Copy link
Contributor

Yozhef commented Mar 24, 2019

@armetiz I probably did not understand you, but you need a new parameter to use rollbar.js. Maybe you tell me more and I will make changes?

@armetiz
Copy link
Contributor

armetiz commented Mar 25, 2019

@Yozhef this issue is not related to rollbar.js.

Telemetry is a rollbar feature to help debugging error.

When a backend error occurred, what's happening before the error could be really helpful ! This is why Telemetry is used for: display events before error.

As I said.
Like many PHP Developper, i'm using monolog to record log: debug, info, warning ...
Telemetry could be used to display recorded logs !

It could be a killer feature ;)

@Yozhef
Copy link
Contributor

Yozhef commented Mar 25, 2019

@armetiz If I correct you understand you say about this Rollbarjs-telemetry. And you need to add to config new params enabling/disabling telemetry?

@armetiz
Copy link
Contributor

armetiz commented Mar 25, 2019

@Yozhef I'm not talking about rollbarjs.

Telemetry allows you to view a 'breadcrumb' of events leading up to an exception.

Telemetry is currently available in the Javascript and iOS SDKs.

This PR is about supporting PHP.

Note:

@Yozhef
Copy link
Contributor

Yozhef commented Mar 25, 2019

@armetiz I understand you this change you need on rollbar-php repo. I didn't understand what I need to add to config. On rollbar-php add telemetry feature?

@armetiz
Copy link
Contributor

armetiz commented Mar 25, 2019

I don't know "how" it have to be done.
I don't know Rollbar API.

Usage example :

  1. Psr\Log\LoggerInterface::info('something useful happened', ['foo' => 'bar'])
  2. Psr\Log\LoggerInterface::debug('something useless happened')
  3. Psr\Log\LoggerInterface::error('system crashed !', ['exception' => $exception])

The error log is reported within a Rollbar occurrence.
The info log is used for telemetry; because it is an event leading up to an exception.
The debug log is dropped because level is too low.

As I said.
I'm using monolog. See FingerCrossHandler

The Rollbar PHP SDK have to be updated to allow developers sending telemetry events using the Rollbar or RollbarLogger class.
The Rollbar PHP Documentation have to be updated to inform developers about how to send telemetry events using SDK.

@ArturMoczulski
Copy link
Contributor

I will be working on this feature shortly. It's great to see there is a lot of interest.

@armetiz
Copy link
Contributor

armetiz commented Feb 2, 2021

any news ?

@armetiz
Copy link
Contributor

armetiz commented May 21, 2021

@ArturMoczulski do you have any news ?

@cyrusradfar
Copy link

@armetiz 👋🏽 just reviewed this thread and will need some more context on current state; however, this sounds like a promising feature to invest in. You've been patient and I'm grateful!

@armetiz
Copy link
Contributor

armetiz commented Feb 28, 2022

Good to know @cyrusradfar !
Note that the FingerCrossHandler may not be the solution.

Note also that for Sentry it's named Breadcrumbs.

@armetiz
Copy link
Contributor

armetiz commented May 23, 2022

@ArturMoczulski ? Will it be supported ?

@danielmorell
Copy link
Collaborator

Hi @armetiz I am the new maintainer of this SDK. I am still working on putting together a roadmap with our product team. We understand the value of telemetry support and appreciate how patient you have been! Once we have a roadmap for this, I will try to make sure to reply to this thread with more details.

@danielmorell danielmorell modified the milestones: v1.8.0, v4.0.0 Jun 8, 2022
@danielmorell danielmorell modified the milestones: v4.0.0, v4.1.0 Jul 29, 2022
@danielmorell
Copy link
Collaborator

After some internal conversation we determined that there needs to be some cleanup work that should happen before we add telemetry support. Unfortunately, the cleanup requires breaking changes e.g. #570.

We want to make sure the changes are working and stable before adding a large new feature like telemetry support. Because of that we are shifting telemetry back from v4.0 to v4.1.

We appreciate everyone's patience!

@armetiz
Copy link
Contributor

armetiz commented Jan 3, 2023

Hi there.

I don't want to be sarcastic, but .. come on, it's been a while!

I can see that #570 will be solved. Telemetry is an important feature to debug error.

Do you plan to work on it this quarter?

Regards

@danielmorell
Copy link
Collaborator

Sorry for the late response! We do plan on working on telemetry this quarter.

@danielmorell danielmorell added the Status: 3 - Construction The request is being worked on. label Mar 22, 2023
@danielmorell
Copy link
Collaborator

This is now being actively developed.

@armetiz
Copy link
Contributor

armetiz commented Mar 22, 2023

Olé !

@fgilio
Copy link

fgilio commented Mar 22, 2023

Wohooo!

@armetiz
Copy link
Contributor

armetiz commented Dec 13, 2023

News?

@danielmorell
Copy link
Collaborator

My goal is to have a beta out before the end of the year.

@danielmorell
Copy link
Collaborator

Ok. So, I am not good at setting goals. Sorry for the delay! Thank you for your patience.

However, the PR is now created and awaiting review. Please feel free to check it out and provide any feedback, questions, or concerns you have on the PR here #634.

@cyrusradfar
Copy link

cyrusradfar commented Feb 17, 2024 via email

@danielmorell
Copy link
Collaborator

Telemetry is now available via v4.1.0-beta. We would appreciate anyone who is willing to test it and provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: 3 - Construction The request is being worked on. Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants