Fatal handler type check #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since fatal error handler is connected to script shutdown function and is executed after every script including ones without fatal errors, error_get_last() might in some cases return last supressed error that was not caught by regular error handler. This causes it to be reported when it should not be according to the configuration.
|
LGTM |
rokob
added a commit
that referenced
this pull request
May 16, 2017
This issue was raised as repro steps in #161 Fix the bug that leads to an error. Also get rid of the error swallowing @ usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fatal error handler is connected to script shutdown function
and is executed after every script including ones without fatal errors,
error_get_last()might in some cases return last suppressed error thatwas not caught by regular error handler. This causes it to be reported
when it should not be according to the configuration.
Steps to reproduce and get a reported occurrence on each script execution (which is a fun way to test your rate limits):
included_errnoto includeE_NOTICE, like this:'included_errno' => E_ALL$handleFataltotrue(it is by default).E_NOTICE: Undefined offset: 0: Undefined offset: 0reported for each execution. I did some digging, it is caused by https://github.com/rollbar/rollbar-php/blob/master/src/Defaults.php#L23