GitHub Issue #153: Issues with using a custom API endpoint #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokob
reviewed
May 30, 2017
| @@ -208,6 +208,38 @@ public function testSender() | |||
| $c->send($p, $this->token); | |||
| } | |||
|
|
|||
| public function testEndpoint() | |||
There was a problem hiding this comment.
Can we add a test that doesn't set the endpoint in the config just to ensure the default is propagating through properly?
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.0.0 the behavior of
base_api_urlwas changed and required additional item/ at the end. This was both not in sync with other SDKs and backwards incompatible.This PR brings back the the behavior from 0.18.2 which doesn't require the item/ URL path.
Also,
base_api_urlis deprecated from now on in favor ofendpointwhich is in sync with how other SDKs work.