GitHub Issue #166: capture_error_stacktraces is not used #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al vars dump config
|
Ready for review. |
rokob
reviewed
May 30, 2017
| @@ -84,7 +84,19 @@ private static function getScrubFields() | |||
|
|
|||
| public function sendMessageTrace($sendMessageTrace = null) | |||
| { | |||
| return $sendMessageTrace ? $sendMessageTrace : $this->defaultSendMessageTrace; | |||
| return $sendMessageTrace !== null ? $sendMessageTrace : $this->defaultSendMessageTrace; | |||
rokob
reviewed
May 30, 2017
src/Defaults.php
Outdated
|
|
||
| public function localVarsDump($localVarsDump = null) | ||
| { | ||
| return $localVarsDump ? $localVarsDump : $this->defaultLocalVarsDump; |
There was a problem hiding this comment.
Shouldn't we follow the same pattern and use
return $localVarsDump !== null ? $localVarsDump : $this->defaultLocalVarsDump;There was a problem hiding this comment.
It doesn't particularly matter considering the default is false, but if we wanted to change that in the future this would matter.
There was a problem hiding this comment.
I changed this. $localVarsDump ? $localVarsDump : $this->defaultLocalVarsDump is buggy
rokob
reviewed
May 30, 2017
| if ($this->captureErrorStacktraces) { | ||
| $backTrace = array_slice( | ||
| debug_backtrace($this->localVarsDump ? 0 : DEBUG_BACKTRACE_IGNORE_ARGS), | ||
| 2 |
There was a problem hiding this comment.
Is this still 2 or should it be 3? I am not sure if we added a level of indirection here.
There was a problem hiding this comment.
Just tested this. Slicing at 2 still produces correct trace depth.
|
LGTM, a couple minor questions but this looks basically good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
capture_error_stacktracesin 1.2.0.This PR is based on PR #178 to pull in changes to
generateErrorWrapper