GitHub Issue #171: why error_sample_rates only use for errors #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparate function as well
|
This is ready for review |
rokob
reviewed
Jul 3, 2017
README.md
Outdated
| @@ -404,6 +404,13 @@ Default: `'production'` | |||
| Default: empty array, meaning all errors are reported. | |||
| </dd> | |||
|
|
|||
| <dt>exception_sample_rates | |||
| </dt> | |||
| <dd>Associative array mapping exception classes to sample rates. Sample rates are ratio out of 1, e.g. 0 is "never report", 1 is "always report", and 0.1 is "report 10% of the time". Sampling is done on a per-exception basis. It also respects class inheritance meaning if Exception is at 1.0 then ExceptionSublcass is also at 1.0, unless explicitly configured otherwise. If ExceptionSubclass is set to 0.5, but Exception is at 1.0 then Exception and all its' subclasses run at 1.0, except for ExceptionSubclass and its' subclasses which run at 0.5. Names of exception classes should NOT be followed with additional `\` for global namespace, i.e. Rollbar\SampleException and NOT \Rollbar\SampleException. | |||
There was a problem hiding this comment.
"should NOT be follow with additional" -> "should NOT be prefixed with additional"
rokob
reviewed
Jul 3, 2017
src/Config.php
Outdated
| public function exceptionSampleRate(\Exception $toLog) | ||
| { | ||
| $sampleRate = 1.0; | ||
|
|
There was a problem hiding this comment.
if $this->exception_sample_rates is empty which will be often because that is the default, we should not go through the work of gathering the class hierarchy for this exception, we should just return 1.0 early.
If there is no configured exception_sample_rates, then there is no reason to do any work to check for the rate for a particular exception, so return early in this case the default value of 1.0 which means don't sample.
rokob
approved these changes
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add
exception_samples_ratesconfig which allows to set sampling rates for exceptions based on exception class.