Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append timestamp to the process id to ensure a unique filename #24

Merged
merged 2 commits into from May 30, 2014

Conversation

rfink
Copy link
Contributor

@rfink rfink commented May 30, 2014

Added a timestamp after the process id in the agent log filename to ensure a unique file name.

This commit resolves #23

@brianr
Copy link
Member

brianr commented May 30, 2014

Nice, I think this makes sense (actually was thinking about it after seeing your pull request from yesterday).

As for the actual time used, time() returns the time in seconds... any reason not to go all the way to microtime() to avoid same-second collisions?

@rfink
Copy link
Contributor Author

rfink commented May 30, 2014

No reason at all, would you like me to update and push again?

@brianr
Copy link
Member

brianr commented May 30, 2014

Please do :)

@rfink
Copy link
Contributor Author

rfink commented May 30, 2014

Change pushed, it should be added to the existing pull request.

Thanks!

brianr added a commit that referenced this pull request May 30, 2014
Append timestamp to the process id to ensure a unique filename
@brianr brianr merged commit fa79c5b into rollbar:master May 30, 2014
@brianr
Copy link
Member

brianr commented May 30, 2014

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding timestamp to filename
2 participants