Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-543-backport-1.x: Add missing transformer config option #544

Merged
merged 3 commits into from Nov 8, 2021
Merged

GH-543-backport-1.x: Add missing transformer config option #544

merged 3 commits into from Nov 8, 2021

Conversation

bxsx
Copy link
Contributor

@bxsx bxsx commented Nov 2, 2021 •
edited

Description of the change

#543 backport to 1.x

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #543

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@bxsx bxsx changed the title GH-543-backport: Add missing transformer config option GH-543-backport-1.x: Add missing transformer config option Nov 2, 2021
@bxsx
Skip transformer for defaults
1de44c0 
(cherry picked from commit 4128f8e)
@bxsx
Keep the options in alphabetical order
6b6a1f7 
(cherry picked from commit 92fc44a)
@bxsx bxsx self-assigned this Nov 3, 2021
@bxsx bxsx merged commit 2f3e4e0 into next/1.x/main Nov 8, 2021
@bxsx bxsx deleted the 1.x-backport-gh543 branch November 8, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishopb bishopb bishopb approved these changes

@akornich akornich Awaiting requested review from akornich

@diegov diegov Awaiting requested review from diegov

@waltjones waltjones Awaiting requested review from waltjones

Assignees

@bxsx bxsx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bxsx @bishopb @danielroehrig