fix: try using __serialize when obj implements \Serializable #567
Conversation
The Serializable interface is now being deprecated in favour of using the magic methods __serialize() and __unserialize(). Some packages decided to start throwing exceptions on their Serializable implementations if the interface methods were called. This commit tries to check if the classes that implement Serializable are already using __serialize() and if they are, it calls that method, instead of the interface one serialize(). If this is the case, we also hide the deprecation notice, since it seems the client code is already preparing to drop \Serializable when the time comes. This should fix issue rollbar#136 on rollbar/rollbar-php-laravel
|
This initially looks like a good direction to take things. I am going to dig into it more this week. |
|
Hello all! Just wanted to pop over here and let you all know we are watching this PR and waiting for it to come through as we need this on our team as well! Thank you for all that you do! |
|
I can not use Rollbar on any of my Laravel 9 projects at the moment. I'm running blind for over a month now, checking logs once a day manually. I don't want to be pushy, but is there any timeline on this issue? |
|
Hi all, we are in the same boat - our rollbar integration has been disabled as we eagerly await this fix. Any chance of this fix making it through approval and out this week? Anything we can do to help speed along the fix? |
|
Same for me. Had to use the forked version to avoid this issue |
|
CC @danielmorell it's been two weeks since this PR was created, any update on your end? There are a handful of us who are currently stuck without good monitoring while we await this fix. |
|
I'm not sure if this fix is up to Rollbar's standards, but it would be great if we could get the ball moving on this, hence the PR. I'm currently running some Laravel applications with Bref on Lambda and if an uncaught exception is thrown my lambdas are stuck on an infinite loop trying to process unhandled exceptions, until Lambda shuts it down. It's a real pain. Note that I do understand that this was a decision taken by Symfony to move people away from using the Serializable interface. |
|
I'm pretty much on the cusp of ditching rollbar in favour of bugsnag at this point. Anyone else..? |
|
@jonnott @jamesaspence et al... hey folks, I won't speak publicly about personal things but @danielmorell had great reason to miss this follow up. I'm watching and we'll push this through. We'll need to find a better way of escalating these lagging issues to our team. If you have suggestions or have experience managing dozens of public repos, I'm open to feedback on tools or integrations. |
There was a problem hiding this comment.
I think this is a good step in the right direction. Thank you @pcoutinho for your work on this! Sorry for the delay!
|
Hey everyone, this has been released in v3.1.3-RC1. Please test it out and provide any feedback you have. If all looks good, we will release the stable v3.1.3. |
|
@danielmorell Can you update the rollbar-php-laravel package to use this release |
|
@roelVerdonschot This is a pre-release version so that would not be wise. You can install it by running... |
|
@danielmorell any rough ETA on when rollbar-php-laravel will be updated with this fixed version? |
|
Hey @jamesaspence, you could install it by running... Please give us any feedback you have on whether it has any issues, so we can make the determination about a stable release. Without any feedback we will release v3.1.3 on 2022/05/30. At that point you can update to the latest version by simply running... |
|
Looks like the bugfix rolled out today - I was able to retrieve it by bumping my rollbar-laravel dependency (which pulled in v3.1.13). I'll be testing it in the next few days! |
Description of the change
The Serializable interface is now being deprecated in favour of using
the magic methods __serialize() and __unserialize().
Some packages decided to start throwing exceptions on their Serializable
implementations if the interface methods were called.
This commit tries to check if the classes that implement Serializable
are already using __serialize() and if they are, it calls that method,
instead of the interface one serialize().
If this is the case, we also hide the deprecation notice, since it seems
the client code is already preparing to drop \Serializable when the time
comes.
Type of change
Related issues
Checklists
Development
Code review