Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix running tests on local machine (mac m1) #568

Merged
merged 3 commits into from
May 16, 2022
Merged

tests: fix running tests on local machine (mac m1) #568

merged 3 commits into from
May 16, 2022

Conversation

Chris53897
Copy link
Contributor

Description of the change

The Value "Off" does not solve to true for empty() on my local machine to run the tests.
I see that it works on github actions.
This fix solves it for my case.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

danielmorell
danielmorell previously approved these changes May 4, 2022
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good addition. The values we want to see would be false, "0", or "Off". All of which are valid (and possible) responses from ini_get().

@danielmorell danielmorell merged commit d6ec7a3 into rollbar:master May 16, 2022
@Chris53897 Chris53897 deleted the feature/fix-phpunit-tests branch April 30, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants