Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comments and type annotations to the EncodedPayload class and payload interfaces #581

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Added comments and type annotations to the EncodedPayload class and payload interfaces #581

merged 1 commit into from
Nov 29, 2022

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This PR primarily adds comments and type annotations to the EncodedPayload class and the two interfaces that impact the payload serialization.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Maintenance General up-keep, or changes that tidy an existing component or process. label Nov 28, 2022
@danielmorell danielmorell added this to the v4.0.0 milestone Nov 28, 2022
waltjones
waltjones approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielmorell danielmorell merged commit 5d74e72 into next/4.0/main Nov 29, 2022
@danielmorell danielmorell deleted the 4.0/added-payload-comments branch November 29, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

@cyrusradfar cyrusradfar Awaiting requested review from cyrusradfar

Assignees
No one assigned
Labels
Type: Maintenance General up-keep, or changes that tidy an existing component or process.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielmorell @waltjones