Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #613 Added response status code to verbose log message. #614

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This resolves issue #613 by adding the response status code from the API to the verbose log, if there is an error response status.

I also updated the associated test. Instead of posting to a non-existent endpoint, I sent an invalid access token. This seems more deterministic since we don't just want an error, we want a specific status code.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component. label Apr 12, 2023
@danielmorell danielmorell added this to the v4.0.1 milestone Apr 12, 2023
danielmorell added a commit that referenced this pull request Apr 14, 2023
…ail-status

Backport of #614 Added response status code to verbose log message.
@danielmorell danielmorell merged commit 8a8d63b into master Apr 18, 2023
@danielmorell danielmorell deleted the fixed/613-verbose-log-fail-status branch April 18, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add status code to failed API send verbose log.
2 participants