Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: allow phpunit 10 #621

Merged
merged 7 commits into from
Apr 29, 2023
Merged

Feat: allow phpunit 10 #621

merged 7 commits into from
Apr 29, 2023

Conversation

Chris53897
Copy link
Contributor

@danielmorell danielmorell self-assigned this Apr 18, 2023
@danielmorell danielmorell self-requested a review April 18, 2023 12:02
@danielmorell danielmorell added the Type: Maintenance General up-keep, or changes that tidy an existing component or process. label Apr 18, 2023
danielmorell
danielmorell approved these changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chris53897 This looks great 🔥

I reverted the drop of support for psr/log v1 since that would be a breaking change for some users, and fixed some of the merge conflicts.

I appreciate the work you put into this! It looks great!

@danielmorell danielmorell merged commit 3ef7481 into rollbar:master Apr 29, 2023
7 checks passed
@Chris53897 Chris53897 deleted the feature/phpunit-10 branch April 30, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmorell danielmorell danielmorell approved these changes

Assignees

@danielmorell danielmorell

Labels
Type: Maintenance General up-keep, or changes that tidy an existing component or process.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Chris53897 @danielmorell @Chris8934