Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #631 Set log message as primary #632

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This resolves #631. When we added support for both a log message and the exception in the log context, it caused the primary log message to be the exception message instead of the log message set when calling the log method. This is backward of what it should be. This PR fixes that issue.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Bug Fix a component so that its behavior aligns with its documentation. label Dec 22, 2023
@danielmorell danielmorell merged commit 72fc135 into master Dec 22, 2023
18 checks passed
@danielmorell danielmorell deleted the fixed/issue-631-message-in-description branch December 22, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception message override log message
2 participants