Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow in Util.merge in IE8 #38

Closed
ghost opened this issue Aug 9, 2014 · 2 comments
Closed

Stack overflow in Util.merge in IE8 #38

ghost opened this issue Aug 9, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 9, 2014

Consistently getting an infinite loop in IE8 at this clause:
c = g[b], d = a[b], g !== d && (j && d && (d.constructor == Object || (e = d.constructor == Array)) ? (e ? (e = !1, f = []) : f = c && c.constructor == Object ? c : {}, g[b] = Util.merge(f, d)) : void 0 !== d && (g[b] = d)) (in Util.merge)

Even Util.merge([], []); will cause the error. I'm using Rollbar in conjunction with Ember, and it seems to be due to Ember extending Array's prototype.

http://emberjs.jsbin.com/dubuzobe/1/

@brianr
Copy link
Member

brianr commented Aug 9, 2014

Thanks for the report! Will investigate.

@coryvirok
Copy link
Contributor

Thanks for pointing this out. I've created a release and will push it out shortly.

mudetroit pushed a commit that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants