feat: add OutputChunk is_entry and facade_module_id (#230)

rolldown · Nov 13, 2023 · 8fcfda3 · 8fcfda3
1 parent dd4ced3
commit 8fcfda3
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 12 deletions.
diff --git a/crates/rolldown/src/bundler/bundle/asset.rs b/crates/rolldown/src/bundler/bundle/asset.rs
@@ -2,4 +2,6 @@
 pub struct OutputChunk {
   pub file_name: String,
   pub code: String,
+  pub is_entry: bool,
+  pub facade_module_id: Option<String>,
 }
diff --git a/crates/rolldown/src/bundler/bundle/bundle.rs b/crates/rolldown/src/bundler/bundle/bundle.rs
@@ -287,7 +287,14 @@ impl<'a> Bundle<'a> {
       .map(|(_chunk_id, c)| {
         let content = c.render(self.graph, &chunk_graph, self.output_options).unwrap();
 
-        OutputChunk { file_name: c.file_name.clone().unwrap(), code: content }
+        OutputChunk {
+          file_name: c.file_name.clone().unwrap(),
+          code: content,
+          is_entry: c.entry_module.is_some(),
+          facade_module_id: c
+            .entry_module
+            .map(|id| self.graph.modules[id].expect_normal().resource_id.prettify().to_string()),
+        }
       })
       .collect::<Vec<_>>();
 

diff --git a/crates/rolldown/src/bundler/module/mod.rs b/crates/rolldown/src/bundler/module/mod.rs
@@ -42,7 +42,7 @@ impl Module {
     }
   }
 
-  pub fn _expect_normal(&self) -> &NormalModule {
+  pub fn expect_normal(&self) -> &NormalModule {
     match self {
       Self::Normal(m) => m,
       Self::External(_) => unreachable!(),

diff --git a/crates/rolldown_binding/index.d.ts b/crates/rolldown_binding/index.d.ts
@@ -45,6 +45,8 @@ export interface OutputOptions {
 export interface OutputChunk {
   code: string
   fileName: string
+  isEntry: boolean
+  facadeModuleId?: string
 }
 export class Bundler {
   constructor(inputOpts: InputOptions)

diff --git a/crates/rolldown_binding/src/bundler.rs b/crates/rolldown_binding/src/bundler.rs
@@ -68,10 +68,7 @@ impl Bundler {
       }
     };
 
-    let output_chunks = outputs
-      .into_iter()
-      .map(|asset| OutputChunk { code: asset.code, file_name: asset.file_name })
-      .collect::<Vec<_>>();
+    let output_chunks = outputs.into_iter().map(Into::into).collect::<Vec<_>>();
     Ok(output_chunks)
   }
 
@@ -95,10 +92,7 @@ impl Bundler {
       }
     };
 
-    let output_chunks = outputs
-      .into_iter()
-      .map(|asset| OutputChunk { code: asset.code, file_name: asset.file_name })
-      .collect::<Vec<_>>();
+    let output_chunks = outputs.into_iter().map(Into::into).collect::<Vec<_>>();
     Ok(output_chunks)
   }
 }
diff --git a/crates/rolldown_binding/src/output_chunk.rs b/crates/rolldown_binding/src/output_chunk.rs
@@ -8,4 +8,17 @@ use serde::Deserialize;
 pub struct OutputChunk {
   pub code: String,
   pub file_name: String,
+  pub is_entry: bool,
+  pub facade_module_id: Option<String>,
+}
+
+impl From<rolldown::OutputChunk> for OutputChunk {
+  fn from(chunk: rolldown::OutputChunk) -> Self {
+    Self {
+      code: chunk.code,
+      file_name: chunk.file_name,
+      is_entry: chunk.is_entry,
+      facade_module_id: chunk.facade_module_id,
+    }
+  }
 }
diff --git a/packages/core/src/utils/transform-to-rollup-output.ts b/packages/core/src/utils/transform-to-rollup-output.ts
@@ -36,13 +36,13 @@ function transformToRollupOutputChunk(chunk: OutputChunk): RollupOutputChunk {
       return unimplemented()
     },
     get facadeModuleId() {
-      return unimplemented()
+      return chunk.facadeModuleId || null
     },
     get isDynamicEntry() {
       return unimplemented()
     },
     get isEntry() {
-      return unimplemented()
+      return chunk.isEntry
     },
     get isImplicitEntry() {
       return unimplemented()