Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Unite using filename instead of file_name #1178

Merged

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented May 20, 2024

Description

Copy link

netlify bot commented May 20, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b7b815e
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/664b48d762526c000835315b

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (4c6a63a) to head (b7b815e).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/rolldown/src/bundler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
- Coverage   86.78%   86.77%   -0.01%     
==========================================
  Files         123      123              
  Lines        6143     6140       -3     
==========================================
- Hits         5331     5328       -3     
  Misses        812      812              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmarks Rust

  • target: main(289fe8b)
  • pr: 05-20-chore_rust_unite_using_filename_instead_of_file_name_(b7b815e)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     31.4±0.53ms        ? ?/sec    1.00     31.4±0.65ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     21.9±0.53ms        ? ?/sec    1.01     22.2±0.73ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     43.1±1.09ms        ? ?/sec    1.00     43.0±1.01ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    324.8±4.88ms        ? ?/sec    1.02    330.7±4.04ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    212.3±3.02ms        ? ?/sec    1.01    213.8±2.18ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    458.8±7.62ms        ? ?/sec    1.02   469.0±13.14ms        ? ?/sec

Copy link

codspeed-hq bot commented May 20, 2024

CodSpeed Performance Report

Merging #1178 will not alter performance

Comparing 05-20-chore_rust_unite_using_filename_instead_of_file_name_ (b7b815e) with main (289fe8b)

Summary

✅ 6 untouched benchmarks

Copy link
Member Author

hyf0 commented May 20, 2024

Merge activity

  • May 20, 1:19 PM EDT: @hyf0 started a stack merge that includes this pull request via Graphite.
  • May 20, 1:20 PM EDT: @hyf0 merged this pull request with Graphite.

@hyf0 hyf0 merged commit 9204e6d into main May 20, 2024
30 checks passed
@hyf0 hyf0 deleted the 05-20-chore_rust_unite_using_filename_instead_of_file_name_ branch May 20, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant