-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(esbuild/packgaejson): enable test_package_json_subpath_import_node_builtin_issue3485 #1186
test(esbuild/packgaejson): enable test_package_json_subpath_import_node_builtin_issue3485 #1186
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Please rename the title to |
The result is not right. However, it's ok we merge them first and solve #1185 later. |
6f98f70
to
684487f
Compare
I'll make an issue of the progress of all esbuild packagejson cases, so that we can track the progress of all esbuild packagejson cases by table, and the reasons for the obstacles and related merge-ins in the MR and other related issue discussions. |
As of this MR, I've finished migrating all the cases that were successfully packaged by esbuild, but there are still a few cases that throw exceptions, so I'll reflect the progress of the migration in the overall issue. |
684487f
to
b483635
Compare
Please rename the title to test(esbuild/packgaejson): enable test_package_json_subpath_import_node_builtin_issue3485
...sts/esbuild/packagejson/test_package_json_subpath_import_node_builtin_issue3485/_config.json
Outdated
Show resolved
Hide resolved
done |
b483635
to
1a99851
Compare
1a99851
to
3774ba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
https://github.com/evanw/esbuild/blob/main/internal/bundler_tests/bundler_packagejson_test.go#L2878
Please check the result of the #1185 issue before merging in this MR.
#1185
#1185
Confirm that the pack is what the rolldown user wants.
even "#fs" will cause the js to crash