Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust/resolve): should point to the correct resolved external module with alias #1253

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented May 27, 2024

Part of #1185.

Description

Copy link

netlify bot commented May 27, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3e82b22
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6654aa1621f058000835d5f7

@hyf0 hyf0 force-pushed the 05-27-fix_rust_resolve_should_point_to_the_correct_resolved_external_module_with_alias branch from 6060a2e to 3e82b22 Compare May 27, 2024 15:43
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (3134b77) to head (3e82b22).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
+ Coverage   87.43%   87.52%   +0.09%     
==========================================
  Files         132      133       +1     
  Lines        6550     6567      +17     
==========================================
+ Hits         5727     5748      +21     
+ Misses        823      819       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmarks Rust

  • target: main(f14dd21)
  • pr: 05-27-fix_rust_resolve_should_point_to_the_correct_resolved_external_module_with_alias(3e82b22)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     29.6±0.60ms        ? ?/sec    1.01     29.8±0.37ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     20.7±0.19ms        ? ?/sec    1.00     20.8±0.14ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     42.4±3.88ms        ? ?/sec    1.00     42.4±1.59ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    314.4±2.66ms        ? ?/sec    1.01    317.1±2.58ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    204.2±1.91ms        ? ?/sec    1.02    207.8±3.58ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    438.4±8.63ms        ? ?/sec    1.01    441.6±9.72ms        ? ?/sec

Copy link

codspeed-hq bot commented May 27, 2024

CodSpeed Performance Report

Merging #1253 will not alter performance

Comparing 05-27-fix_rust_resolve_should_point_to_the_correct_resolved_external_module_with_alias (3e82b22) with main (f4bd84f)

Summary

✅ 6 untouched benchmarks

@hyf0 hyf0 merged commit 4667d32 into main May 27, 2024
28 checks passed
@hyf0 hyf0 deleted the 05-27-fix_rust_resolve_should_point_to_the_correct_resolved_external_module_with_alias branch May 27, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant