Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable preserve annotation comments by default #1384

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

Description

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a0a441e
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66738fc02952aa00085aa430

Copy link

github-actions bot commented Jun 12, 2024

Benchmarks Rust

group                                 pr                                     target
-----                                 --                                     ------
bundle/bundle@rome-ts                 1.01    100.6±1.86ms        ? ?/sec    1.00     99.3±0.89ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap       1.01    118.3±0.74ms        ? ?/sec    1.00    117.1±1.31ms        ? ?/sec
bundle/bundle@threejs                 1.00     27.8±0.29ms        ? ?/sec    1.01     28.2±1.07ms        ? ?/sec
bundle/bundle@threejs-sourcemap       1.02     36.8±1.37ms        ? ?/sec    1.00     36.2±0.89ms        ? ?/sec
bundle/bundle@threejs10x              1.01   313.2±11.15ms        ? ?/sec    1.00    310.0±2.61ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap    1.01    401.2±5.55ms        ? ?/sec    1.00    398.8±8.41ms        ? ?/sec
scan/scan@rome-ts                     1.00     80.1±0.58ms        ? ?/sec    1.00     79.9±0.79ms        ? ?/sec
scan/scan@rome-ts-sourcemap           1.00     80.3±0.77ms        ? ?/sec    1.00     80.0±0.67ms        ? ?/sec
scan/scan@threejs                     1.00     20.4±0.12ms        ? ?/sec    1.01     20.5±0.62ms        ? ?/sec
scan/scan@threejs-sourcemap           1.00     20.4±0.08ms        ? ?/sec    1.00     20.5±0.26ms        ? ?/sec
scan/scan@threejs10x                  1.00    205.6±1.62ms        ? ?/sec    1.01    207.4±1.94ms        ? ?/sec
scan/scan@threejs10x-sourcemap        1.00    205.3±2.46ms        ? ?/sec    1.00    205.4±1.06ms        ? ?/sec

Copy link

codspeed-hq bot commented Jun 12, 2024

CodSpeed Performance Report

Merging #1384 will not alter performance

Comparing chore/enable-preserve-comments (a0a441e) with main (39761b0)

Summary

✅ 12 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY changed the title Chore/enable preserve comments chore: enable preserve comments by default Jun 19, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title chore: enable preserve comments by default chore: enable preserve annotation comments by default Jun 19, 2024
@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/enable-preserve-comments branch 2 times, most recently from 45d5f49 to 0f8fb7b Compare June 19, 2024 09:40
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (39761b0) to head (a0a441e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   86.02%   86.04%   +0.02%     
==========================================
  Files         151      151              
  Lines        7562     7566       +4     
==========================================
+ Hits         6505     6510       +5     
+ Misses       1057     1056       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 19, 2024 14:23
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 5e155ed Jun 20, 2024
27 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the chore/enable-preserve-comments branch June 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants