fix ValueFormatTransformer broken empty-values

rollerworks-graveyard · Jun 29, 2015 · 9c66f5e · 9c66f5e
1 parent a26ae86
commit 9c66f5e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Extension/Core/DataTransformer/ValueFormatTransformer.php b/src/Extension/Core/DataTransformer/ValueFormatTransformer.php
@@ -126,7 +126,7 @@ private function validateEmptyValueOption($emptyValue, array $mappingFields)
         }
 
         foreach ($emptyValue as $field => $value) {
-            if (!in_array($field, $mappingFields, true)) {
+            if (!array_key_exists($field, $mappingFields)) {
                 throw new TransformationFailedException(sprintf('Empty-value of mapping field "%s" doesn\'t exists in field mapping.', $field));
             }
 

diff --git a/tests/Extension/Core/DataTransformer/ValueFormatTransformerTest.php b/tests/Extension/Core/DataTransformer/ValueFormatTransformerTest.php
@@ -45,7 +45,7 @@ public function testTransformEmptyValueWithArray()
 
     public function testTransformEmptyValuePerFieldWithArray()
     {
-        $transformer = new ValueFormatTransformer(['id' => '0', 'name' => 'NV'], ',', null, ['id', 'name']);
+        $transformer = new ValueFormatTransformer(['id' => '0', 'name' => 'NV'], ',', null, ['id' => 'user.id', 'name' => 'name']);
 
         $this->assertEquals('foo', $transformer->transform('foo'));
         $this->assertEquals('', $transformer->transform(null));