This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Refactor datagrid view handling #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove usage of Interfaces for Views - Rename properties to remove "view" part eg. "cellViews" becomes "cells" - Make all View properties public - Remove Datagrid and Column awareness from Views, makes serialzation possible - Intialize rows during the construct (and not per iteration) - ColumnOrderListener is removed as changing the order is no longer possible Changing the order should be done in the Datagrid configuration instead.
sstok
added a commit
that referenced
this pull request
Feb 3, 2016
This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |no | |New Feature? |no | |BC Breaks? |yes| |Deprecations?|no | |Fixed Tickets| | - Remove set-data filtering from Datagrid, data must be in the correct format when provided. A Datagrid should not hold configuration, **and** handle the correct data format. - Rename properties to remove "view" part eg. "cellViews" becomes "cells" - Remove usage of Interfaces for Views (classes with public properties only) - Make all View properties public - Remove Datagrid and Column awareness from Views, makes serialzation possible - Intialize rows during the construct (and not per iteration) (no performance problems noticed) - ColumnOrderListener is removed as changing the order is no longer possible Changing the order should be done in the Datagrid configuration instead. The DatagridView is less changeable (changing columns after creation is no longer possible) but this is a very limited use-case (note: hiding columns is still possible). Commits ------- 072937e Remove data filtering from Datagrid, data must be in the correct format f754f54 Refactor Views for beter performance and less clutter 30ca58f Rename to ff0e756 Update UPGRADE instructions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Datagrid should not hold configuration, and handle the correct data format.
eg. "cellViews" becomes "cells"
Changing the order should be done in the Datagrid configuration instead.
The DatagridView is less changeable (changing columns after creation is no longer possible) but this is a very limited use-case (note: hiding columns is still possible).