This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Make Datagrid configuration immutable #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the size the Datagrid interface, and keep things simple, changing the columns on a datagrid is no longer possible and the event-dispatcher for updating a DatagridView is replaced by a single viewBuilder callable. Setting the data on a datagrid is now possible only once! As there should not be a need to change this after the view is created.
sstok
added a commit
that referenced
this pull request
Feb 6, 2016
This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |no | |New Feature? |no | |BC Breaks? |ye | |Deprecations?|no | |Fixed Tickets| | This is the last refactoring pull-request (for now), the datagrid system is trimmed down immensely to make integration easier, execution faster. And code complexity lower. In the end the datagrid has a clear focus on what it does, and can be used for. Input data processing is no longer a part of the Datagrid, but should be done before the Datagrid is populated with data (which will be possible with integration adapters). With this pr the following changed: * The (default) Datagrid no longer allows to change the columns (you can only set them in the constructor), adding/removing or replacing columns on a datagrid is no longer possible. * Setting data is only possible once now, calling `setData` twice will result in an exception. * The event-dispatcher for updating the DatagridView is replaced with a single view-builder callable (use decoration to chain them). ~~*UPGRADE instructions needs to be updated before this pr can be merged 馃槆*~~ Commits ------- c051ca5 Make Datagrid configuration immutable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last refactoring pull-request (for now), the datagrid system is
trimmed down immensely to make integration easier, execution faster.
And code complexity lower.
In the end the datagrid has a clear focus on what it does, and can be used for.
Input data processing is no longer a part of the Datagrid, but should be done before
the Datagrid is populated with data (which will be possible with integration adapters).
With this pr the following changed:
adding/removing or replacing columns on a datagrid is no longer possible.
setDatatwice will result inan exception.
single view-builder callable (use decoration to chain them).
UPGRADE instructions needs to be updated before this pr can be merged 馃槆