This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
PHP 7 refactoring and improvements #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow to modify after creation (each Datagrid is unique) - Pass name when actually creating - Strict types - Less code complexity
|
That's strange, Edit: Mismatch between local configuration and configuration of the web interface. |
sstok
added a commit
that referenced
this pull request
Sep 21, 2016
This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |yes| |New Feature? |yes| |BC Breaks? |yes| |Deprecations?|no | |Fixed Tickets| | Work in progress. Commits ------- a2d75f1 Add php strict typehint and return-type 234796a Refactor the DatagridBuilder 29f3f88 disable simplified_null_return for .styleci.yml fdc77f9 Correct CS 320f227 Require newer version of PHPUnit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.