This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Simplify internal logic #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sstok
commented
Sep 21, 2016
sstok
commented
| Q | A |
|---|---|
| Bug Fix? | yes |
| New Feature? | no |
| BC Breaks? | no |
| Deprecations? | no |
| Fixed Tickets |
* The `currency_field` and `input_field` options are removed. * When the value is a string without currency it's transformed with the `currency` option. * When the value is a string with a currency, eg. `EUR 12.00` it's transformed with 'EUR' currency. * When the value is an array, the keys `currency` and `amount` are expected to be present. Currency can be `null`, then the value of the `currency` option is used.
This extension has been broken since the refactoring of the Datagrid. And it’s more a niche use-case anyway.
And some tests for PreloadedExtension
sstok
added a commit
that referenced
this pull request
Sep 22, 2016
This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |yes| |New Feature? |no | |BC Breaks? |no | |Deprecations?|no | |Fixed Tickets| | Commits ------- f790e6f Simplify ActionType internal logic 62a5ea8 Remove dead code in ColumnOrderExtension 872e7b0 Refactor MoneyType and transformer de2d908 Remove precision from IntegerToLocalizedStringTransformer fd81ee4 Type hints for Core Extension transformer classes 358c50a Remove broken ColumnOrder Extension 13e60ce Stricter checking of ‘empty_value’ in TextType c7a7dae Rewrote some code to be less complex 59f28b2 Fix PreloadedExtension compatibility f4ad3d3 correct CS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.