This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Introduce the BaseType / data_provider for subcols #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sstok
commented
Sep 26, 2016
•
sstok
commented
| Q | A |
|---|---|
| Bug Fix? | no |
| New Feature? | yes |
| BC Breaks? | no |
| Deprecations? | no |
| Fixed Tickets |
Both ColumnType and CompoundColumnType share a set of common logic, which was duplicated. The CompoundColumnBuilder now allows to configure a `data_provider` that will be used as a default for all sub-columns. No more duplicating a data_provider for Actions 😆
This logic was already performed in the Twig DatagridRender, but keeping it in the BaseType reduces duplicating logic and allows for greater flexibility. Note that child columns inherit the name of there parent column (which was the main reason for CompoundColumn refactoring, as they first were not aware of there parent). But not that a child-column doesn’t have direct access to the view of the parent.
sstok
added a commit
that referenced
this pull request
Sep 26, 2016
This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |no | |New Feature? |yes| |BC Breaks? |no | |Deprecations?|no | |Fixed Tickets| | Commits ------- d3dbb9a Introduce the BaseType / data_provider for subcols 83f853e Provide the template block_names by BaseType 4a98433 Update the UPGRADE instructions 1a66103 Correct CS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.