Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build 2.0 #15

Merged
merged 15 commits into from
Apr 10, 2015
Merged

Build 2.0 #15

merged 15 commits into from
Apr 10, 2015

Conversation

lesnitsky
Copy link
Member

No description provided.

@dzmitry-varabei
Copy link
Member

Awesome 👍
but our favicon icon is missing in bin folder 😭

@lesnitsky
Copy link
Member Author

I assume robots.txt and apple-touch-icon-precompressed.png also should be copied to dist folder?

@dzmitry-varabei
Copy link
Member

we can drop robots.txt but apple-touch-icon-precompressed.png can be useful

@lesnitsky
Copy link
Member Author

Ok, it's already done in a8fe2b1
@DaQuirm, can you please take a look? 👽

@DaQuirm
Copy link
Contributor

DaQuirm commented Apr 8, 2015

Taking a look, yessir 😺

DaQuirm
DaQuirm reviewed Apr 9, 2015
View reviewed changes
gulpfile.js
var options = {
src: 'app',
staging: '.tmp',
dest: 'appBin'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use camel-case here?..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only god knows 😸

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for ditching camelCase and adopting snake case project-wide

@DaQuirm
Copy link
Contributor

DaQuirm commented Apr 9, 2015

The mustache task overwrites archive.html in /app. Should it do that?

@lesnitsky
Copy link
Member Author

We can drop archive.html in app folder and write rendered mustache template to .tmp folder

@lesnitsky
Copy link
Member Author

I vote for ditching camelCase and adopt snake case project-wide

I think we can create a couple of issues related to camelCase ➡️ snake-case and mustache task. Any other comments?

@DaQuirm
Copy link
Contributor

DaQuirm commented Apr 10, 2015

Not from me, no. LGTM 😺
If we create the issues, that is.

@lesnitsky
Copy link
Member Author

#16
#17
Created 😃

@DaQuirm
Copy link
Contributor

DaQuirm commented Apr 10, 2015

You're a superhero! 👏

@lesnitsky
Copy link
Member Author

ROFL 😆

@DaQuirm
Copy link
Contributor

DaQuirm commented Apr 10, 2015

Come on, let's merge it and have an awesome build process! :shipit:

DaQuirm added a commit that referenced this pull request Apr 10, 2015
@DaQuirm
Merge pull request #15 from rolling-scopes/build-2.0
08a4bb3 
Build 2.0
@DaQuirm DaQuirm merged commit 08a4bb3 into master Apr 10, 2015
@dzmitry-varabei dzmitry-varabei deleted the build-2.0 branch May 25, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lesnitsky @dzmitry-varabei @DaQuirm