transformMixedEsModules shouldn't replace typeof exports

[gluck]

• Rollup Plugin Name: @rollup/plugin-commonjs
• Rollup Plugin Version: 21.0.0

Expected Behavior / Situation

If an ESM file is transformed with transformMixedEsModules=true (for require support), it shouldn't replace typeof exports by 'object' and leave it as-is (or replace by 'undefined' ?)

Actual Behavior / Situation

Right now the bundle fails with exports is not defined because of code in ESM such as lodash-es:
https://github.com/lodash/lodash/blob/es/isBuffer.js#L5

var freeExports = typeof exports == 'object' && exports && !exports.nodeType && exports;
// becomes:
var freeExports = exports && !exports.nodeType && exports;

(lodash-es itself doesn't require transformMixedEsModules, but other parts of the bundle do)

Modification Proposal

If esModule=true do not transform typeof module/exports/module.exports into 'object', as they'll likely open invalid code paths in an ESM.

(I can PR with tests if agreed)

[yunsii]

Any progress? lodash-es cause the same error, when I use Vite with transformMixedEsModules=true.

[lukastaegert]

I added a fix to #1038

[yunsii]

I added a fix to #1038

Hello, when will it be released?

[shellscape]

@theprimone we don't have a release schedule. please exercise patience.

[yunsii]

@theprimone we don't have a release schedule. please exercise patience.

Well，how can I make a workaround？It causes error after bundled, though I try to configure exclude.

[yunsii]

It looks like version @rollup/plugin-commonjs@22.0.0-4 fixes the problem for now, detail: https://unpkg.com/browse/@rollup/plugin-commonjs@22.0.0-4/dist/index.es.js

[webhao]

@yunsii I didn't solve it.update@rollup/plugin-commonjs@22.0.0-9,use commonjsOptions: { transformMixedEsModules: true, strictRequires: true, }

[yunsii]

@yunsii I didn't solve it.update@rollup/plugin-commonjs@22.0.0-9,use commonjsOptions: { transformMixedEsModules: true, strictRequires: true, }

The same error: exports is not defined? I replace require with import ... from ... and remove commonjs plugin finnally 😂

[mccxiv]

Workaround while waiting for the fix to release:

Add window.exports = undefined before anything else executes.
For me, I had to do it in a separate script tag above the main file:

<script>
  // Workaround for https://github.com/rollup/plugins/issues/1014
  window.exports = undefined
</script>

[superchangme]

help me vite 2.6.8 still has this problem Uncaught ReferenceError: exports is not defined