[@rollup/plugin-node-resolve] error detecte if a string matches the name of a Node.js builtin module

[dixdiydiz]

• Rollup Plugin Name: @rollup/plugin-node-resolve
• Rollup Plugin Version: 13.1.3

Expected Behavior

'fs/promises' can be deleted as builtin module

Actual Behavior

(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
fs/promises (imported by xxx.ts)

Additional Information

plugins/packages/node-resolve/src/index.js

Line 169 in 4c5e8fd

const importeeIsBuiltin = builtins.has(importee);

is-builtin-module lib: https://github.com/sindresorhus/is-builtin-module
isBuiltinModule('fs/promises');
//=> true

isBuiltinModule('node:fs/promises');
//=> true

[lukastaegert]

Good catch! Would you be willing to contribute a PR to replace builtin-modules with is-builtin-module?

[isker]

I have just coincidentally had the same problem and opened a PR to fix: #1124