You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Doing a dynamic require of a bulit-in node module should succeed, regardless of the settings of dynamicRequireTargets, ignoreDynamicRequire.
Actual Behavior
The dynamic require will throw in all possible configurations of these settings.
Additional Information
I encountered this issue while bundling the latest version of nock (13.5.1).
It does a dynamic require of http and https, but this require will always throw if the target is an esm module run in node.js.
If ignoreDynamicRequire is false, it'll throw with Could not dynamically require \"http\". Please configure the dynamicRequireTargets or/and ignoreDynamicRequires option of @rollup/plugin-commonjs appropriately for this require call to work.. If ignoreDynamicRequire is true, it will throw due to require not being defined inside the esm module.
It should be relatively easy to fix it so this behavior is supported, but probably best done by someone familiar with the codebase 😅
The text was updated successfully, but these errors were encountered:
http
andhttps
modules due to bundler limitations nock/nock#2586Expected Behavior
Doing a dynamic require of a bulit-in node module should succeed, regardless of the settings of
dynamicRequireTargets
,ignoreDynamicRequire
.Actual Behavior
The dynamic require will throw in all possible configurations of these settings.
Additional Information
I encountered this issue while bundling the latest version of nock (13.5.1).
It does a dynamic require of
http
andhttps
, but this require will always throw if the target is an esm module run in node.js.If
ignoreDynamicRequire
isfalse
, it'll throw withCould not dynamically require \"http\". Please configure the dynamicRequireTargets or/and ignoreDynamicRequires option of @rollup/plugin-commonjs appropriately for this require call to work.
. IfignoreDynamicRequire
istrue
, it will throw due torequire
not being defined inside theesm
module.It should be relatively easy to fix it so this behavior is supported, but probably best done by someone familiar with the codebase 😅
The text was updated successfully, but these errors were encountered: