Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@rollup/babel has a dep on @types/estree@0.0.39 which breaks @types/eslint #640

Closed
kentcdodds opened this issue Nov 9, 2020 · 7 comments

Comments

@kentcdodds
Copy link

Expected Behavior

@types/estree@0.0.41 (latest) should be installed and deduped

Actual Behavior

@types/estree@0.0.39 gets installed and doesn't play nice with other types packages

Additional Information

More info in this PR: #639

@shellscape
Copy link
Collaborator

@Andarist any chance you have a moment to tackle this?

@Andarist
Copy link
Member

I'm afraid that I won't have time to handle this soon. With 2 small kids at home and multiple OSS projects to maintain I'm really struggling with finding time lately to do all the things I'd like. Given this require a dependency update and not something really specific to the plugin itself I would say that anyone can do it (a team contributor or an external one).

I'm not sure about that breaking change in the @rollup/pluginutils - but maybe the upgrade could be done in a backward-compatible manner by joining the options with cwd to match the @rollup/pluginutils@3 behavior? That would allow us to avoid a new major for @rollup/plugin-babel

@tianyingchun
Copy link

I think all rollup plguin should be upgrade @rollup/pluginutils from 3.1.0 to 4.1.0 this issue can be resolved.

@Andarist
Copy link
Member

Right, I would prefer to avoid a breaking change in the @rollup/plugin-babel though so ideally it should be explored if it's possible to do this upgrade in such a way. The issue stays open for anyone that cares about this and would like to contribute a PR for this.

@stale
Copy link

stale bot commented Jan 30, 2021

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it.

@stale stale bot closed this as completed Jan 30, 2021
@dasa
Copy link
Contributor

dasa commented Jul 21, 2021

Right, I would prefer to avoid a breaking change in the @rollup/plugin-babel though so ideally it should be explored if it's possible to do this upgrade in such a way.

Would it be possible to move @types/estree from dependencies to devDependencies in a 3.x release of @rollup/pluginutils?

@sir-captainmorgan21
Copy link

@shellscape @Andarist any word on this? Still an issue with breaking eslint. @rollup/pluginutils has been updated to point to the latest of @types/estree, but a good amount of the other plugins are pointing to an older version of @rollup/pluginutils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants