Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): fix lint issues #1270

Merged
merged 1 commit into from
Sep 24, 2022
Merged

chore(repo): fix lint issues #1270

merged 1 commit into from
Sep 24, 2022

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Sep 23, 2022

Rollup Plugin Name: all

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

linting issues in two packages were breaking the build for unrelated PRs. This is fixed here by adding proper comments. Also, the lock file is down-graded to match the version of pnpm installed as a dependency. It was accidentally upgraded by some of the recent PRs.

Additionally, I needed to add a fix for Node 18 in the Babel tests.

Comment on lines +175 to +176
// source-map uses the presence of fetch to detect browser environments which
// breaks in Node 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

export default class MyClass {}

// eslint-disable-next-line @typescript-eslint/no-unused-vars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's somewhat surprising that @typescript-eslint doesnt detect this as used - maybe worth updating those deps and if it doesn't help then an issue could be raised there about this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated ESLint but the issue persisted, maybe I would really need to change ESLint config directly, but as this is just a test, maybe we leave it as it is.

pnpm-lock.yaml Outdated Show resolved Hide resolved
Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits from my side - feel free to ignore all/some of them.

@shellscape shellscape changed the title chore(all): fix lint issues chore(repo): fix lint issues Sep 23, 2022
@lukastaegert
Copy link
Member Author

All done from my side. If there are no further concerns, I will merge tomorrow morning.

@lukastaegert
Copy link
Member Author

Ok, maybe it is not that simple. I will look into the auto-install issues tomorrow.

@lukastaegert lukastaegert force-pushed the fix-lint-issues branch 4 times, most recently from 48ac907 to 6e64204 Compare September 24, 2022 04:37
@lukastaegert
Copy link
Member Author

Ok, I also needed to adjust the pnpm version in the CI scripts. One breaking pnpm change I came across is that arguments are now passed differently to scripts in some cases. That means pnpm build -- --sourcemap will now fail as it will pass both -- and --sourcemap to the build script. This change applies to running scripts except test, which still wants the -- parameter. Basically what I had to do:

  • Move pnpm parameters (--workspace-root) to the left of the script name
  • Remove -- from script calls except test

This is all working now nicely. I will merge this now as it is also blocking me very much, if there are still issues, I will be glad to make another PR.

@lukastaegert lukastaegert merged commit 4e85ed7 into master Sep 24, 2022
@lukastaegert lukastaegert deleted the fix-lint-issues branch September 24, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants