Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yaml): Add extensions?: string[] to RollupYamlOptions #1506

Merged
merged 2 commits into from
Jun 19, 2023
Merged

fix(yaml): Add extensions?: string[] to RollupYamlOptions #1506

merged 2 commits into from
Jun 19, 2023

Conversation

janosh
Copy link
Contributor

@janosh janosh commented May 24, 2023 •
edited
Loading

Follow up to #1445.

Rollup Plugin Name: yaml

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Follow up to #1445.

Fixes:

Screenshot 2023-05-24 at 11 45 25

@janosh janosh requested a review from shellscape as a code owner May 24, 2023 18:46
@janosh janosh changed the title Add extensions?: string[] to RollupYamlOptions fix(yaml): Add extensions?: string[] to RollupYamlOptions May 24, 2023
@shellscape
Copy link
Collaborator

Our PR and Issue templates are not optional. please replace abs update the PR template.

@janosh
Copy link
Contributor Author

janosh commented May 26, 2023 •
edited
Loading

Done

shellscape
shellscape requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We require new or updated tests for every PR opened. In this case, we need to assert that the type is correct by updating the test/types.ts file. Please add the extensions option to that code and we should be good.

@janosh
Copy link
Contributor Author

janosh commented Jun 7, 2023 •
edited
Loading

@shellscape Thanks for the pointer. Added.

@shellscape shellscape merged commit 0cc9ef6 into rollup:master Jun 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellscape shellscape shellscape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janosh @shellscape