Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(virtual): accept a function resolver for the id option #1722

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

qzsiniong
Copy link

@qzsiniong qzsiniong commented May 23, 2024

Rollup Plugin Name: @rollup/plugin-virtual

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:
resolves #1721

Description

Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please change up the name of the new type you've introduced, so it avoids any potential confusion.

packages/virtual/types/index.d.ts Outdated Show resolved Hide resolved
@shellscape shellscape changed the title feat: Allow @rollup/plugin-virtual to be a function that takes a module id feat(virtual): accept a function resolver for the id option Jun 5, 2024
Co-authored-by: Andrew Powell <shellscape@users.noreply.github.com>
@qzsiniong qzsiniong force-pushed the master branch 2 times, most recently from c9eb94b to 7c33adf Compare June 6, 2024 02:08
@qzsiniong
Copy link
Author

@shellscape any problem?Please review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow @rollup/plugin-virtual to be a function that takes a module ID
2 participants